Hi "Nuno, I love your patch! Perhaps something to improve: [auto build test WARNING on dtor-input/next] [also build test WARNING on next-20220711] [cannot apply to brgl/gpio/for-next hid/for-next linus/master v5.19-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Nuno-S/adp5588-keys-refactor-and-fw-properties-support/20220708-173730 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220712/202207121357.JpS5DGdP-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> smatch warnings: drivers/input/keyboard/adp5588-keys.c:342 adp5588_gpio_irq_handle() warn: unsigned 'hwirq' is never less than zero. vim +/hwirq +342 drivers/input/keyboard/adp5588-keys.c 333 334 static void adp5588_gpio_irq_handle(struct adp5588_kpad *kpad, int key_val, 335 int key_press) 336 { 337 unsigned int irq, gpio = key_val - GPI_PIN_BASE, irq_type, hwirq; 338 struct i2c_client *client = kpad->client; 339 struct irq_data *desc; 340 341 hwirq = adp5588_gpiomap_get_hwirq(kpad->gpiomap, gpio, kpad->gc.ngpio); > 342 if (hwirq < 0) { 343 dev_err(&client->dev, "Could not get hwirq for key(%u)\n", key_val); 344 return; 345 } 346 347 irq = irq_find_mapping(kpad->gc.irq.domain, hwirq); 348 if (irq <= 0) 349 return; 350 351 desc = irq_get_irq_data(irq); 352 if (!desc) { 353 dev_err(&client->dev, "Could not get irq(%u) data\n", irq); 354 return; 355 } 356 357 irq_type = irqd_get_trigger_type(desc); 358 359 /* 360 * Default is active low which means key_press is asserted on 361 * the falling edge. 362 */ 363 if ((irq_type & IRQ_TYPE_EDGE_RISING && !key_press) || 364 (irq_type & IRQ_TYPE_EDGE_FALLING && key_press)) 365 handle_nested_irq(irq); 366 } 367 -- 0-DAY CI Kernel Test Service https://01.org/lkp
