On Wed, Jul 06, 2022 at 11:27:34AM +0300, Dmitry Baryshkov wrote: > On Tue, 5 Jul 2022 at 23:56, Christian Marangi <ansuelsmth@xxxxxxxxx> wrote: > > > > Convert clk-rpm driver to parent_data API and change parent names to cxo > > and pxo instead of the board variant as pxo_board is an ancient name and > > pxo should be used instead. > > > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > > --- > > drivers/clk/qcom/clk-rpm.c | 24 ++++++++++++++++-------- > > 1 file changed, 16 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c > > index a18811c38018..d45a8b0fc97c 100644 > > --- a/drivers/clk/qcom/clk-rpm.c > > +++ b/drivers/clk/qcom/clk-rpm.c > > @@ -23,6 +23,14 @@ > > #define QCOM_RPM_SCALING_ENABLE_ID 0x2 > > #define QCOM_RPM_XO_MODE_ON 0x2 > > > > +static const struct clk_parent_data gcc_pxo[] = { > > + { .fw_name = "pxo", .name = "pxo" }, > > This means that the core clock would look for the DT clock named 'pxo' > with the fallback to the global clock named 'pxo'. Fallback is > required to keep compatibility with older DT files, not having the > clocks/clock-names properties. > For all other platforms we were using as a fallback the 'pxo_board' > clock (defined in the DT) rather than the 'pxo' (hackily injected by > the gcc driver). > I'd suggest following this pattern and using .fw_name = "pxo', .name = > "pxo_board". We were discussing this to the lcc driver. Problematic topic, yes will follow the pattern just to not change things. > > Same applies to the CXO clock. > > > +}; > > + > > > -- > With best wishes > Dmitry -- Ansuel