On Tue, Jul 05, 2022 at 08:13:55PM +0200, Krzysztof Kozlowski wrote: > On 05/07/2022 14:43, Johan Hovold wrote: > > So you suggest we keep this regulator for all PHY variants even though > > it was probably only needed for UFS on some older SoCs? > > No. I commented only that reason is not a good one. The proper reason > could be: there is or there is no such pin in the device or the history > tells that adding it for all variants was a mistake. Ok, I'll include it since it was there as an optional regulator from the start and hence implicitly made part of the binding for later PHYs even though it likely only applies to the older MSM8996/98. If anyone has access to the documentation they can drop it later. Johan