On 05/07/2022 11:42, Johan Hovold wrote: > Only UFS PHY nodes in mainline have a vddp-ref-clk supply. Drop it from > the PCIe PHY binding. > That's not really good reason. Either the hardware uses ref-clk supply or not. Now it looks like you copied everything from common schema and clean things up. That's not how it should be organize. It's okay to copy existing bindings which are applicable and then in separate patch deprecate things or remove pieces which are not correct. But all this in assumption that the first copy already selected only applicable parts. Best regards, Krzysztof