On 05/07/2022 13:46, Johan Hovold wrote: >> It's okay to copy existing bindings which are applicable and then in >> separate patch deprecate things or remove pieces which are not correct. >> But all this in assumption that the first copy already selected only >> applicable parts. > > But how would you be able to tell what parts I left out from the > original copy They are obvious and immediately visible. I see old bindings and new bindings - no troubles to compare. I review new bindings - everything in place. I don't want to review old code, inapplicable code. The patch I am reviewing (the one doing the split) must bring correct bindings, except these few differences like deprecated stuff. > unless I first do the split and then explicitly remove > things that were presumably *never* applicable and just happened to be > added because all bindings where combined in one large mess of a schema? Best regards, Krzysztof
