On Tue, Jun 28, 2022 at 8:25 PM Colin Foster <colin.foster@xxxxxxxxxxxxxxxx> wrote: > On Tue, Jun 28, 2022 at 02:53:49PM +0200, Andy Shevchenko wrote: > > On Tue, Jun 28, 2022 at 10:17 AM Colin Foster > > <colin.foster@xxxxxxxxxxxxxxxx> wrote: ... > > > builtin_platform_driver(ocelot_pinctrl_driver); > > > > This contradicts the logic behind this change. Perhaps you need to > > move to module_platform_driver(). (Yes, I think functionally it won't > > be any changes if ->remove() is not needed, but for the sake of > > logical correctness...) > > I'll do this. Thanks. > > Process question: If I make this change is it typical to remove all > Reviewed-By tags? I assume "yes" I would not. This change is logical continuation and I truly believe every reviewer will agree on it. -- With Best Regards, Andy Shevchenko
