On Tue, Jun 28, 2022 at 10:17 AM Colin Foster <colin.foster@xxxxxxxxxxxxxxxx> wrote: > > Work is being done to allow external control of Ocelot chips. When pinctrl > drivers are used internally, it wouldn't make much sense to allow them to > be loaded as modules. In the case where the Ocelot chip is controlled > externally, this scenario becomes practical. ... > builtin_platform_driver(ocelot_pinctrl_driver); This contradicts the logic behind this change. Perhaps you need to move to module_platform_driver(). (Yes, I think functionally it won't be any changes if ->remove() is not needed, but for the sake of logical correctness...) -- With Best Regards, Andy Shevchenko
