Re: [PATCH v6 07/11] arm64: dts: qcom: sdm630: fix gpu's interconnect path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-05-21 18:51:07, Krzysztof Kozlowski wrote:
> On 21/05/2022 18:17, Marijn Suijten wrote:
> > 
> > And also added my Reviewed-by there.  I think it is normal to have a
> > Reviewed-by on top of a Suggested-by/Reported-by, so that I as reviewer
> > confirm the contents of the patch?
> 
> The review tag is not used to confirm anything like that.

It is used to acknowledge that I agree on (confirm) the contents of the
patch as per how a review usually works.  I have reviewed the patch,
double-checked the numbers on my end.  That's the "contents of the
patch"?

> > Since this is the third patch missing these, It may just have been an
> > oversight.
> 
> If your review was meeting the criteria of "Reviewer's statement of
> oversight", then of course should be added here.

That's what I said above, the Reviewed-by goes on top of the Reported-by
as the latter doesn't imply the former at all.

- Marijn



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux