Re: [PATCH v6 01/11] arm64: dts: qcom: sdm630: disable dsi0/dsi0_phy by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-05-21 18:49:36, Krzysztof Kozlowski wrote:
> On 21/05/2022 18:06, Marijn Suijten wrote:
> > On 2022-05-21 18:20:39, Dmitry Baryshkov wrote:
> >> Follow the typical practice and keep DSI0/DSI0 PHY disabled by default.
> >> They should be enabled in the board DT files. No existing boards use
> >> them at this moment.
> >>
> >> Suggested-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > 
> > I also added my:
> > 
> > Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> > 
> > To v5, to confirm the Suggested-by.
> 
> Reviewed-by tag is not used to confirm other tags like reported or
> suggested. It means you performed the review and you state what is
> described in "Reviewer's statement of oversight".

That is obviously implied, otherwise I wouldn't have sent a Reviewed-by
in the first place.

However, I don't think Suggested-by quite carries the load of a
Reviewed-by (at all...), so I don't understand why my Reviewed-by's have
strangely been picked up for every patch except those where my name is
already listed as Suggested-by or Reported-by, those are completely
separate things.

- Marijn



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux