On 11 May 2022 09:48, Primoz Fiser wrote:
> >> Optionally disable watchdog during suspend (if enabled) and re-enable
> >> it upon resume.
> >> This enables boards to sleep without being interrupted by the watchdog.
> >>
> >> This patch is based on commit f6c98b08381c ("watchdog: da9062: add
> >> power management ops") and commit 8541673d2a5f ("watchdog: da9062: fix
> >> power management ops") and brings the same functionality to DA9063.
> >
> > There's a WATCHDOG_PD bit (set to 0) to achieve this I believe, and thus
> > removes the need for the suspend/resume PM functions. Is this something
> you've
> > tried? Also seems to be present for DA9061/2 as well so can't remember why
> that
> > wasn't used there.
>
> Ideally one should be able to use WATCHDOG_PD bit indeed.
>
> However there are boards out there which don't have the ability to use
> the PMIC's powerdown/active mode due to PCB design and thus PMIC is left
> enabled during suspend i.e. cannot use the POWERDOWN mode.
>
> Check mailing list correspondence [1] which already gave explanation why
> there was a need to implement such quirks for da9062 and the need to
> handle this in software instead of hardware.
>
> Links:
>
> [1]
> https://lore.kernel.org/all/20191128171931.22563-1-m.felsch@xxxxxxxxxxxxxx/
At least I'm consistent in my first response :)
Yes I remember the discussion now. Thanks for the reminder. In which case:
Reviewed-by: Adam Thomson <DLG-Adam.Thomson.Opensource@xxxxxxxxxxxxxx>
