Re: [PATCH 2/3] watchdog: da9063: optionally disable watchdog during suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9. 05. 22 12:38, DLG Adam Thomson wrote:
On 22 April 2022 08:27, Primoz Fiser wrote:

Optionally disable watchdog during suspend (if enabled) and re-enable
it upon resume.
This enables boards to sleep without being interrupted by the watchdog.

This patch is based on commit f6c98b08381c ("watchdog: da9062: add
power management ops") and commit 8541673d2a5f ("watchdog: da9062: fix
power management ops") and brings the same functionality to DA9063.

There's a WATCHDOG_PD bit (set to 0) to achieve this I believe, and thus
removes the need for the suspend/resume PM functions. Is this something you've
tried? Also seems to be present for DA9061/2 as well so can't remember why that
wasn't used there.

Ideally one should be able to use WATCHDOG_PD bit indeed.

However there are boards out there which don't have the ability to use the PMIC's powerdown/active mode due to PCB design and thus PMIC is left enabled during suspend i.e. cannot use the POWERDOWN mode.

Check mailing list correspondence [1] which already gave explanation why there was a need to implement such quirks for da9062 and the need to handle this in software instead of hardware.

Links:

[1] https://lore.kernel.org/all/20191128171931.22563-1-m.felsch@xxxxxxxxxxxxxx/



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux