Hi Andy: Thank you for your comment and it will be addressed. Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> 於 2022年5月10日 週二 下午6:08寫道： > > On Tue, May 10, 2022 at 05:16:47PM +0800, Tyrone Ting wrote: > > From: Tali Perry <tali.perry1@xxxxxxxxx> > > > > Change the way of getting NPCM system manager reigster (GCR) > > and still maintain the old mechanism as a fallback if getting > > nuvoton,sys-mgr fails while working with the legacy devicetree > > file. > > ... > > > @@ -2236,6 +2236,7 @@ static int npcm_i2c_probe_bus(struct platform_device *pdev) > > static struct regmap *clk_regmap; > > int irq; > > int ret; > > + struct device_node *np = pdev->dev.of_node; > > Can we keep "longer line first" order? > > -- > With Best Regards, > Andy Shevchenko > > Best Regards, Tyrone
