Hi Miquel,
On Thu, Apr 21, 2022 at 10:51 AM Miquel Raynal
<miquel.raynal@xxxxxxxxxxx> wrote:
> Describe the two DMA controllers available on this SoC.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Still, a few comments below, valid for both instances...
> --- a/arch/arm/boot/dts/r9a06g032.dtsi
> +++ b/arch/arm/boot/dts/r9a06g032.dtsi
> @@ -200,6 +200,36 @@ nand_controller: nand-controller@40102000 {
> status = "disabled";
> };
>
> + dma0: dma-controller@40104000 {
> + compatible = "renesas,r9a06g032-dma", "renesas,rzn1-dma";
> + reg = <0x40104000 0x1000>;
> + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "hclk";
> + clocks = <&sysctrl R9A06G032_HCLK_DMA0>;
> + dma-channels = <8>;
> + dma-requests = <16>;
> + dma-masters = <1>;
> + #dma-cells = <3>;
> + block_size = <0xfff>;
> + data_width = <3>;
This property is deprecated, in favor of "dma-width".
> + status = "disabled";
Why not keep it enabled?
> + };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
