Re: [PATCH v3 3/5] arm64: dts: nuvoton: Add initial support for MA35D1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2022/4/18 下午 08:20, Krzysztof Kozlowski wrote:
On 18/04/2022 10:27, Jacky Huang wrote:
Add the initial device tree files for Nuvoton MA35D1 Soc.

(...)

+	gic: interrupt-controller@50800000 {
The unit address does not match first reg property. Don't you have
warnings with this?

Yes, I will modify it as
gic: interrupt-controller@50801000


+		compatible = "arm,gic-400";
+		#interrupt-cells = <3>;
+		interrupt-parent = <&gic>;
+		interrupt-controller;
+		reg = <0x0 0x50801000 0x0 0x1000>,
+		      <0x0 0x50802000 0x0 0x2000>,
+		      <0x0 0x50804000 0x0 0x2000>,
+		      <0x0 0x50806000 0x0 0x2000>;
+		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_RAW(0x13) |
+			      IRQ_TYPE_LEVEL_HIGH)>;
+	};
+};
Best regards,
Krzysztof

Thanks for your review.

Jacky Huang



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux