Re: [PATCH v3 5/5] dt-bindings: arm: Add initial bindings for Nuvoton Platform

[Jacky Huang <ychuang3@xxxxxxxxxxx>]

On 2022/4/18 下午 08:11, Krzysztof Kozlowski wrote:
> On 18/04/2022 10:27, Jacky Huang wrote:
> > +properties:
> > +  $nodename:
> > +    const: '/'
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - nuvoton,ma35d1
> > +          - nuvoton,ma35d1-evb
> > +          - nuvoton,ma35d1-iot
> > +          - nuvoton,ma35d1-som512
> > +          - nuvoton,ma35d1-som1g
> This does not match your DTS and does not look reasonable (SoC
> compatible should not be part of this enum). Check some other board
> bindings for examples.
>
>
> Best regards,
> Krzysztof

I would like to modify it as follows:

description: |
  Boards with an ARMv8 based Nuvoton SoC shall have the following
  properties.

properties:
  $nodename:
    const: '/'
  compatible:
    oneOf:

      - description: MA35D1 evaluation board
        items:
          - const: nuvoton,ma35d1-evb
          - const: nuvoton,ma35d1

      - description: MA35D1 IoT board
        items:
          - const: nuvoton,ma35d1-iot
          - const: nuvoton,ma35d1

      - description: MA35D1 SOM board with 512MB DDR
        items:
          - const: nuvoton,ma35d1-som512
          - const: nuvoton,ma35d1

      - description: MA35D1 SOM board with 1GB DDR
        items:
          - const: nuvoton,ma35d1-som1g
          - const: nuvoton,ma35d1

additionalProperties: true



Thank you very much.
Jacky Huang