On 20/04/2022 05:50, Changming Huang wrote: > Add DT Binding doc for semtech sx1301 > > Signed-off-by: Changming Huang <jerry.huang@xxxxxxx> > --- > changes in v3: > - add the dt-bindings > > .../bindings/spi/semtech,sx1301.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/semtech,sx1301.yaml > > diff --git a/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml b/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml > new file mode 100644 > index 000000000000..f65fb5809218 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/semtech,sx1301.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/semtech,sx1301.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Semtech sx1301 devicetree bindings Remove "devicetree bindings" and add instead short description (type) of the device (SPI controller?). > + > +allOf: > + - $ref: "spi-controller.yaml" allOf after maintainers. > + > +maintainers: > + - Changming Huang <jerry.huang@xxxxxxx> > + > +properties: > + compatible: > + const: semtech,sx1301 > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: true > + > + fsl,spi-cs-sck-delay: true > + > + fsl,spi-sck-cs-delay: true > + > +required: > + - compatible > + - reg > + - spi-max-frequency > + > +additionalProperties: false > + > +examples: > + - | > + mikrobus@0 { Isn't MikroBUS more than SPI, but you implement here only it's part? If so, name it just "spi". Best regards, Krzysztof
