> -----Original Message----- > From: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Sent: 2022年4月15日 4:45 > To: Hongxing Zhu <hongxing.zhu@xxxxxxx>; p.zabel@xxxxxxxxxxxxxx; > bhelgaas@xxxxxxxxxx; lorenzo.pieralisi@xxxxxxx; robh@xxxxxxxxxx; > shawnguo@xxxxxxxxxx; vkoul@xxxxxxxxxx; alexander.stein@xxxxxxxxxxxxxxx > Cc: linux-phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; dl-linux-imx > <linux-imx@xxxxxxx> > Subject: Re: [PATCH v2 0/7] Add the iMX8MP PCIe support > > Hi Richard, > > I didn't get around to see what's wrong with the PCIe on my EVK, so I wasn't > able to do any reworks to the series. As I will be on vacation from tomorrow > until Apr. 25th, I'll just leave some more comments on this series for your > consideration. Hi Lucas: Got that, thanks. Have a good holiday. Best Regards Richard Zhu > > Regards, > Lucas > > Am Montag, dem 07.03.2022 um 17:07 +0800 schrieb Richard Zhu: > > Based on the i.MX8MP GPC and blk-ctrl patch-set[1] issued by Lucas and > > the following commits. > > - one codes refine patch-set[5]. > > - two Fixes[2],[3]. > > - one binding commit[4]. > > - some dts changes in Shawn's git if you want to test PCIe on i.MX8MM > EVK. > > b4d36c10bf17 arm64: dts: imx8mm-evk: Add the pcie support on > imx8mm evk board > > aaeba6a8e226 arm64: dts: imx8mm: Add the pcie support > > cfc5078432ca arm64: dts: imx8mm: Add the pcie phy support > > > > Sorry about that there may be some conflictions when do the codes merge. > > I'm waiting for the ack now, and will re-base them in a proper sequence later. > > > > This series patches add the i.MX8MP PCIe support and tested on i.MX8MM > > EVK and i.MX8MP EVk boards. The PCIe NVME works fine on both boards. > > > > - i.MX8MP PCIe PHY has two resets refer to the i.MX8MM PCIe PHY. > > Add one more PHY reset for i.MX8MP PCIe PHY accordingly. > > - Add the i.MX8MP PCIe PHY support in the i.MX8M PCIe PHY driver. > > And share as much as possible codes with i.MX8MM PCIe PHY. > > - Add the i.MX8MP PCIe support in binding document, DTS files, and PCIe > > driver. > > > > Main changes v1-->v2: > > - It's my fault forget including Vinod, re-send v2 after include Vinod > > and linux-phy@xxxxxxxxxxxxxxxxxxx. > > - List the basements of this patch-set. The branch, codes changes and so on. > > - Clean up some useless register and bit definitions in #3 patch. > > > > [1]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp > > > atchwork.kernel.org%2Fproject%2Flinux-arm-kernel%2Fcover%2F2022022820 > 1 > > > 731.3330192-1-l.stach%40pengutronix.de%2F&data=04%7C01%7Chongx > ing. > > > zhu%40nxp.com%7C3e8710b45fcd4516145908da1e57ad9b%7C686ea1d3bc2 > b4c6fa92 > > > cd99c5c301635%7C0%7C1%7C637855659162145906%7CUnknown%7CTWF > pbGZsb3d8eyJ > > > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > C3000 > > > &sdata=p758ZvzD9wSh23Bcz29e%2BbvVi6BfmvDqIgh4yzR3ACs%3D&am > p;reserv > > ed=0 > > [2]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp > > > atchwork.ozlabs.org%2Fproject%2Flinux-pci%2Fpatch%2F1646289275-17813- > 1 > > > -git-send-email-hongxing.zhu%40nxp.com%2F&data=04%7C01%7Chongxi > ng. > > > zhu%40nxp.com%7C3e8710b45fcd4516145908da1e57ad9b%7C686ea1d3bc2 > b4c6fa92 > > > cd99c5c301635%7C0%7C1%7C637855659162145906%7CUnknown%7CTWF > pbGZsb3d8eyJ > > > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > C3000 > > > &sdata=PKa0bhjfgg%2B74KtKYEtMLtar%2BMkw6od3IZkkjd5U6fM%3D&a > mp;rese > > rved=0 > > [3]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp > > > atchwork.ozlabs.org%2Fproject%2Flinux-pci%2Fpatch%2F1645672013-8949-1 > - > > > git-send-email-hongxing.zhu%40nxp.com%2F&data=04%7C01%7Chongxi > ng.z > > > hu%40nxp.com%7C3e8710b45fcd4516145908da1e57ad9b%7C686ea1d3bc2 > b4c6fa92c > > > d99c5c301635%7C0%7C1%7C637855659162145906%7CUnknown%7CTWFp > bGZsb3d8eyJW > > > IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000& > > > amp;sdata=wCnAZqH22CWRBc%2BNJOTdfFUEcGcb9JtziIVJsUMSXVc%3D& > ;reserve > > d=0 > > [4]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp > > > atchwork.ozlabs.org%2Fproject%2Flinux-pci%2Fpatch%2F1646293805-18248- > 1 > > > -git-send-email-hongxing.zhu%40nxp.com%2F&data=04%7C01%7Chongxi > ng. > > > zhu%40nxp.com%7C3e8710b45fcd4516145908da1e57ad9b%7C686ea1d3bc2 > b4c6fa92 > > > cd99c5c301635%7C0%7C1%7C637855659162145906%7CUnknown%7CTWF > pbGZsb3d8eyJ > > > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > C3000 > > > &sdata=U221NuIhee%2FF9Yf%2B28pFwVlg8fi3m694qbdfPZs%2BHEw%3 > D&re > > served=0 > > [5]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp > > > atchwork.ozlabs.org%2Fproject%2Flinux-pci%2Fcover%2F1645760667-10510- > 1 > > > -git-send-email-hongxing.zhu%40nxp.com%2F&data=04%7C01%7Chongxi > ng. > > > zhu%40nxp.com%7C3e8710b45fcd4516145908da1e57ad9b%7C686ea1d3bc2 > b4c6fa92 > > > cd99c5c301635%7C0%7C1%7C637855659162145906%7CUnknown%7CTWF > pbGZsb3d8eyJ > > > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > C3000 > > > &sdata=9KHzoq6kMFAL%2FVnG6GMvY%2FdbfzaOlZf9y4Y%2FuVrEKV4%3 > D&re > > served=0 > > > > NOTE: > > Based git > > <git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git> > > Based branch <pci/imx6> > > > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 + > > Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml | 4 +- > > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 55 > ++++++++++++++++++++++ > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 46 > ++++++++++++++++++- > > drivers/pci/controller/dwc/pci-imx6.c | 19 > +++++++- > > drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 205 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++----------------- > > drivers/reset/reset-imx7.c | 1 + > > 7 files changed, 286 insertions(+), 45 deletions(-) > > > > [PATCH v2 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support > > [PATCH v2 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding [PATCH v2 > > 3/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY [PATCH v2 4/7] > > dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible [PATCH v2 5/7] > > arm64: dts: imx8mp: add the iMX8MP PCIe support [PATCH v2 6/7] arm64: > > dts: imx8mp-evk: Add PCIe support [PATCH v2 7/7] PCI: imx6: Add the > > iMX8MP PCIe support >
