On Thu, Apr 14, 2022 at 07:06:12AM +0000, qinjian[覃健] wrote: > > > > +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > > > +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > > > + > > > +#define XTAL 27000000 > > > > This looks like frequency which usually does not belong to bindings. Why > > do you need it here? > > > > OK, I'll remove it. If that's the input frequency to the clock controller and it could possibly change, then it should be defined in DT with a 'fixed-clock' node and 'clocks' property in the clock controller. Rob
