RE: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: RE: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver
From: qinjian[覃健] <qinjian@xxxxxxxxxxx>
Date: Thu, 14 Apr 2022 07:06:12 +0000
Accept-language: zh-CN, en-US
Cc: "robh+dt@xxxxxxxxxx" <robh+dt@xxxxxxxxxx>, "mturquette@xxxxxxxxxxxx" <mturquette@xxxxxxxxxxxx>, "sboyd@xxxxxxxxxx" <sboyd@xxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "maz@xxxxxxxxxx" <maz@xxxxxxxxxx>, "p.zabel@xxxxxxxxxxxxxx" <p.zabel@xxxxxxxxxxxxxx>, "linux@xxxxxxxxxxxxxxx" <linux@xxxxxxxxxxxxxxx>, "arnd@xxxxxxxx" <arnd@xxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "devicetree@xxxxxxxxxxxxxxx" <devicetree@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-clk@xxxxxxxxxxxxxxx" <linux-clk@xxxxxxxxxxxxxxx>
In-reply-to: <c2a7f2e0-1a21-bb0c-9221-c184cfaa3626@linaro.org>

> > +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
> > +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
> > +
> > +#define XTAL            27000000
> 
> This looks like frequency which usually does not belong to bindings. Why
> do you need it here?
> 

OK, I'll remove it.

Follow-Ups:
- Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver
  - From: Rob Herring

References:
- [PATCH v13 0/9] Add Sunplus SP7021 SoC Support
  - From: Qin Jian
- [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver
  - From: Qin Jian
- Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver
  - From: Krzysztof Kozlowski

Prev by Date: Re: [PATCH 4/4] dt-bindings: soc: qcom,rpmh-rsc: convert to dtschema
Next by Date: [PATCH v8 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support
Previous by thread: Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver
Next by thread: Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver
Index(es):
- Date
- Thread

[Index of Archives] [Device Tree Compilter] [Device Tree Spec] [Linux Driver Backports] [Video for Linux] [Linux USB Devel] [Linux PCI Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [XFree86] [Yosemite Backpacking]