On 11/04/2022 08:49, Qin Jian wrote: > Add documentation to describe Sunplus SP7021 clock driver bindings. (...) > diff --git a/include/dt-bindings/clock/sp-sp7021.h b/include/dt-bindings/clock/sp-sp7021.h > new file mode 100644 > index 000000000..de8ef5601 > --- /dev/null > +++ b/include/dt-bindings/clock/sp-sp7021.h > @@ -0,0 +1,90 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (C) Sunplus Technology Co., Ltd. > + * All rights reserved. > + */ > +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > + > +#define XTAL 27000000 This looks like frequency which usually does not belong to bindings. Why do you need it here? Best regards, Krzysztof
