On 08/04/2022 12:24, Rex-BC Chen wrote: >> >> You need to describe the type. I am a bit confused whether this is a >> cci >> (so cci-control-port property?) or an interconnect (so interconnect >> property)... It does not look like a generic property, so you need >> vendor prefix. > > Hello Krzysztof, > > Thanks for your review. > > Yes, this cci is not arm's cci (cci-control-port property), and it's > mediatek's cci. I will revise this name to "mtk-cci" in next version. Vendor is "mediatek" and comma comes after it. See devicetree spec paragraph 2.3.1. > >> >>> + For details, please refer to >>> + Documentation/devicetree/bindings/devfreq/mtk-cci.yaml >> >> Such file does not exist. > > This mediatek cci is still upstreaming in this patch: > message-id:20220408052150.22536-2-johnson.wang@xxxxxxxxxxxx > > Do you have suggestion that I should put this reference? > Or I just remove it and describe the mediatek cci in detail? It's ok, but you need to keep path/filename updated. Best regards, Krzysztof
