On Wed, Apr 06, 2022 at 03:21:56PM +1200, Chris Packham wrote: > This pinctrl driver supports the 98DX25xx and 98DX35xx family of chips > from Marvell. It is based on the Marvell SDK with additions for various > (non-gpio) pin configurations based on the datasheet. > > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> > --- > > Notes: > Changes in v3: > - Use mmio instead of syscon Hi Chris syscon is used when the register space is shared with other devices. Is that not the case here? You can share mmio spaces, but you have to use the correct call to reserve it, so that the system knows it is to be shared. Or are all the pinctl registers contiguous and you are only reserve just the registers you need, leaving other drivers fee to take what they need? I'm just trying to ensure you are not going to have trouble later when you add other drivers. Andrew