On Sun, Jan 30, 2022 at 10:59 PM Marc Zyngier <maz@xxxxxxxxxx> wrote: > > On Sun, 30 Jan 2022 13:09:21 +0000, > Guo Ren <guoren@xxxxxxxxxx> wrote: > > > > On Sun, Jan 30, 2022 at 6:28 PM Marc Zyngier <maz@xxxxxxxxxx> wrote: > > > > > > On Sun, 30 Jan 2022 04:39:34 +0000, > > > Guo Ren <guoren@xxxxxxxxxx> wrote: > > > > > > > > > +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", plic_init); > > > > I think we should give clear info in /proc/interrupts. I hope we could > > > > keep thead_plic_init. > > > > > > Why? There is no material difference at the driver level, and > > > /proc/interrupts won't be the target of a branding exercise (which > > > this series seems to be all about). > > It's not a branding exercise, the series just correct the broken code > > & incorrect /proc/interrupts display. > > There is *nothing* incorrect in /proc/interrupt. If anything, changing > the string *is* an ABI change, for no good reason. I've minimized the modification to fix the problem, please have a look: https://lore.kernel.org/linux-riscv/20220130135634.1213301-3-guoren@xxxxxxxxxx/T/#u > > M. > > -- > Without deviation from the norm, progress is not possible. -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/
