On Wed, 19 Jan 2022, Zong Li wrote:
> Improve PRCI driver to reduce the complexity, we remove the SoCs C files
> by putting all stuff in each SoCs header files, and include these
> SoCs-specific header files in core of PRCI. It can also avoid the W=1
> kernel build warnings about variable defined but not used
> [-Wunused-const-variable=], like commit 487dc7bb6a0c ("clk: sifive:
> fu540-prci: Declare static const variable 'prci_clk_fu540' where it's
> used") does.
>
> Signed-off-by: Zong Li <zong.li@xxxxxxxxxx>
> Suggested-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/clk/sifive/Makefile | 2 +-
> drivers/clk/sifive/fu540-prci.c | 89 --------------------
> drivers/clk/sifive/fu540-prci.h | 91 ++++++++++++++++++++-
> drivers/clk/sifive/fu740-prci.c | 134 -------------------------------
> drivers/clk/sifive/fu740-prci.h | 130 +++++++++++++++++++++++++++++-
> drivers/clk/sifive/sifive-prci.c | 5 --
> 6 files changed, 214 insertions(+), 237 deletions(-)
> delete mode 100644 drivers/clk/sifive/fu540-prci.c
> delete mode 100644 drivers/clk/sifive/fu740-prci.c
This is the sort of thing I was after.
This patch at least LGTM.
Reviewed-by: Lee Jones <lee.jones@xxxxxxxxxx>
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
