On Wed, Jan 19, 2022 at 5:28 PM Zong Li <zong.li@xxxxxxxxxx> wrote:
>
> This patch set tries to improve the PRCI driver to reduce the
> complexity, we remove the SoCs C files by putting putting all stuff in
> each SoCs header file, and include these SoCs-specific header files in
> core of PRCI. It can also avoid the W=1 kernel build warnings about
> variable defined but not used [-Wunused-const-variable=], like 'commit
> 487dc7bb6a0c ("clk: sifive:fu540-prci: Declare static const variable
> 'prci_clk_fu540' where it's used")' does.
>
> This patch set also contains the dt-bindings and dts change, because
> we change the macro name for fu540 and fu740 by adding the prefix
> respectively.
>
> Thanks all for your review and suggestions.
>
> Zong Li (4):
> dt-bindings: change the macro name of prci in header files and example
> riscv: dts: Change the macro name of prci in each device node
> clk: sifive: Add SoCs prefix in each SoCs-dependent data
> clk: sifive: Move all stuff into SoCs header files from C files
>
> .../devicetree/bindings/gpio/sifive,gpio.yaml | 2 +-
> .../bindings/pci/sifive,fu740-pcie.yaml | 2 +-
> .../bindings/serial/sifive-serial.yaml | 2 +-
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 22 +--
> arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 26 ++--
> drivers/clk/sifive/Makefile | 2 +-
> drivers/clk/sifive/fu540-prci.c | 89 ------------
> drivers/clk/sifive/fu540-prci.h | 91 +++++++++++-
> drivers/clk/sifive/fu740-prci.c | 134 ------------------
> drivers/clk/sifive/fu740-prci.h | 130 ++++++++++++++++-
> drivers/clk/sifive/sifive-prci.c | 5 -
> include/dt-bindings/clock/sifive-fu540-prci.h | 8 +-
> include/dt-bindings/clock/sifive-fu740-prci.h | 18 +--
> 13 files changed, 254 insertions(+), 277 deletions(-)
> delete mode 100644 drivers/clk/sifive/fu540-prci.c
> delete mode 100644 drivers/clk/sifive/fu740-prci.c
>
> --
> 2.31.1
>
Hi all, thanks for your review, I'd like to know if anything else can
be improved in this patch, or it might be good enough to be picked up.
Thanks.
