On Wed, 27 Aug 2014, Doug Anderson wrote: > On Wed, Aug 27, 2014 at 6:39 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote: > >> +static int rk808_probe(struct i2c_client *client, > >> + const struct i2c_device_id *id) > >> +{ > >> + int ret; > >> + int pm_off = 0; > >> + struct rk808 *rk808; > >> + struct device_node *np = client->dev.of_node; > > > > Are you prepared for np == NULL? > > Given that the driver no longer supports getting its config from > platform data, I think it simply depends on OF now. It seems like we > could add a "&& OF" to the dependencies. Is that OK with you? If the driver depends on OF, then it should be specified in the Kconfig. > It doesn't hurt to still add a check for np == NULL and bail out, though. If we're depending on OF, then there's no real need to do this. And of_property_read_bool() does a NULL check on np anyway, so not checking is still okay. I was just wondering if not checking was a mistake or intentional? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html