Re: [PATCH 1/4] dt-bindings: arm: fsl: add PHYTEC phyGATE Tauri i.MX6 ULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

On 13. 12. 21 20:15, Rob Herring wrote:
On Wed, Dec 01, 2021 at 01:53:24PM +0100, Andrej Picej wrote:
Add devicetree bindings for phyGATE Tauri board with phyCORE-i.MX6 ULL.

Signed-off-by: Andrej Picej <andrej.picej@xxxxxxxxx>
---
  Documentation/devicetree/bindings/arm/fsl.yaml | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 0b595b26061f..9c37f22b6c61 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -602,6 +602,15 @@ properties:
            - const: phytec,imx6ull-pcl063  # PHYTEC phyCORE-i.MX 6ULL
            - const: fsl,imx6ull
+ - description: i.MX6ULL PHYTEC phyGATE-Tauri
+        items:
+          - enum:
+              - phytec,imx6ull-phygate-tauri-emmc
+              - phytec,imx6ull-phygate-tauri-nand
+          - const: phytec,imx6ull-phygate-tauri # PHYTEC phyGATE-Tauri with i.MX6 ULL

Is there really a need for 2 compatibles here? Either
phytec,imx6ull-phygate-tauri is specific enough (as nand/emmc can be
described elsewhere) or you need
phytec,imx6ull-phygate-tauri-emmc/phytec,imx6ull-phygate-tauri-nand.

sorry for late reply. Yes, I think we need both. We have two board types for Tauri, one with eMMC and the other with NAND. Depending on this the NAND or eMMC gets enabled. The same logic is already used with other PHYTEC boards (e.g. Segin and Mira). Or did you had something other in mind?


+          - const: phytec,imx6ull-pcl063        # PHYTEC phyCORE-i.MX 6ULL
+          - const: fsl,imx6ull
+
        - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL Modules
          items:
            - enum:
--
2.25.1





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux