On Thu, 16 Dec 2021 07:08:10 +0000,
Qin Jian <qinjian@xxxxxxxxxxx> wrote:
>
> Add interrupt controller driver for Sunplus SP7021 SoC.
>
> This is the interrupt controller in P-chip which collects all interrupt
> sources in P-chip and routes them to parent interrupt controller in C-chip.
>
> Signed-off-by: Qin Jian <qinjian@xxxxxxxxxxx>
> ---
> Fix the comments from Marc.
No, you didn't.
> +void sp_intc_set_ext(u32 hwirq, int ext_num)
> +{
> + sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num);
> +}
> +EXPORT_SYMBOL_GPL(sp_intc_set_ext);
I already commented on this. In case it wasn't clear, this is a strong
NAK to random low-level hacks like this.
M.
--
Without deviation from the norm, progress is not possible.
