> + ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE); > + if (ret < 0) > + return ret; > + > + if (ret & MDIO_PMA_EXTABLE_BT1) This pattern of reading the MDIO_PMA_EXTABLE register and then looking for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which is expected to change is it? So i wounder if it should be read once and stored away? Andrew