Hi Niklas, On Tue, Nov 9, 2021 at 10:09 AM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > On 2021-11-09 09:43:33 +0100, Niklas Söderlund wrote: > > > > linux/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dt.yaml: > > > > thermal-zones: sensor3-thermal:cooling-maps:map0:contribution:0:0: > > > > 1024 is greater than the maximum of 100 > > > > From schema: Documentation/devicetree/bindings/thermal/thermal-zones.yaml > > > > > > > > This validation error appears to be pervasive across all of these > > > > bindings, but changing that will be more invasive and require someone to > > > > perform dedicated testing with the thermal drivers to ensure that the > > > > updates to the ranges do not cause unexpected side effects. > > > > > > Niklas? > > > > I will have a look. The thermal driver is the one driver where I have > > automated CI test running. > > So the core of the issue is that the definition of the property changed > in the txt to yaml conversion. The original definition was, > > Optional property: > - contribution: The cooling contribution to the thermal zone of the > Type: unsigned referred cooling device at the referred trip point. > Size: one cell The contribution is a ratio of the sum > of all cooling contributions within a thermal zone. > > While the new binding states, > > contribution: > $ref: /schemas/types.yaml#/definitions/uint32 > minimum: 0 > maximum: 100 > description: > The percentage contribution of the cooling devices at the > specific trip temperature referenced in this map > to this thermal zone > > Looking at the real world usage of this only 2 out of 17 platforms sets > a contribution value less or equal to 100. I will send a patch to fix > the bindings. Given Rob said he applied your patch[1], does that mean this series is good to be applied? Thanks! [1] https://lore.kernel.org/all/YaU4XuiaJgEjGCdQ@xxxxxxxxxxxxxxxxxx/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
