On Fri, 08 Oct 2021 10:29:31 +0200, RafaÅ? MiÅ?ecki wrote: > From: RafaÅ? MiÅ?ecki <rafal@xxxxxxxxxx> > > This reverts commit 2ae80900f239484069569380e1fc4340fd6e0089. > > My rework was unneeded & wrong. It replaced a clear & correct "reg" > property usage with a custom "offset" one. > > Back then I didn't understand how to properly handle CRU block binding. > I heard / read about syscon and tried to use it in a totally invalid > way. That change also missed Rob's review (obviously). > > Northstar's pin controller is a simple consistent hardware block that > can be cleanly mapped using a 0x24 long reg space. > > Since the rework commit there wasn't any follow up modifying in-kernel > DTS files to use the new binding. Broadcom also isn't known to use that > bugged binding. There is close to zero chance this revert may actually > cause problems / regressions. > > This commit is a simple revert. Example binding may (should) be updated > / cleaned up but that can be handled separately. > > Signed-off-by: RafaÅ? MiÅ?ecki <rafal@xxxxxxxxxx> > --- > .../bindings/pinctrl/brcm,ns-pinmux.yaml | 23 +++++++++++-------- > 1 file changed, 13 insertions(+), 10 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml: cru-bus@1800c100: pinctrl: 'reg' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,cru.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml: cru-bus@1800c100: pinctrl: 'reg-names' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,cru.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml: cru-bus@1800c100: pinctrl: 'offset' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,cru.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml: pinctrl: 'reg' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml: pinctrl: 'reg-names' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml: pinctrl: 'offset' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.example.dt.yaml: cru@1800c100: $nodename:0: 'cru@1800c100' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/simple-bus.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1538264 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
