Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/05/2014 05:32 PM, Alan Cox wrote:
On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote:
On 08/05/2014 04:24 PM, Matthias Brugger wrote:

(...)

+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/serial_8250.h>
+#include <linux/of_irq.h>
+#include <linux/of_platform.h>
+#include <linux/platform_device.h>
+#include <linux/clk.h>
+#include <linux/pm_runtime.h>
+#include "8250.h"
+
Better if we have includes in alphabetical order..

So 8250.h would be first and it wouldn't compile ???

Can we stick to serious critiques ?

The local headers should be at the end of all includes..?


--
Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux