Hi Anand,
sorry for the late reply
I have three very small comments below, apart from these, this is looking good!
On Tue, Aug 17, 2021 at 6:17 AM Anand Moon <linux.amoon@xxxxxxxxx> wrote:
>
> Add missing usb phy power node for usb node fix below warning.
> P5V0 regulator supply input voltage range to USB host controller.
> As described in the C1+ schematics, GPIO GPIOAO_5 is used to
> enable input power to USB ports, set it to Active Low.
I would phrase this last sentence as:
"enable USB VBUS on the Micro-USB port using an active high signal"
My idea here is to 1) clarify that it's about enabling USB VBUS only
on the Micro-USB port and 2) use "active high" like the changes inside
the patch itself
> [ 1.260772] dwc2 c90c0000.usb: Looking up vbus-supply from device tree
> [ 1.260784] dwc2 c90c0000.usb: Looking up vbus-supply property in
> mode /soc/usb@c90c0000 failed
>
> Fixes: 2eb79a4d15ff (ARM: dts: meson: enabling the USB Host
> controller on Odroid-C1/C1+ board)
>
please drop this empty line
[...]
> @@ -119,7 +136,6 @@ vcc_3v3: regulator-vcc-3v3 {
> regulator-name = "VCC3V3";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> -
I don't think that we should make any VCC3V3 regulator changes in this patch
so please keep this empty line as-is.
Best regards,
Martin
