On 31.07.14 10:22:19, Rob Herring wrote: > On Thu, Jul 31, 2014 at 7:34 AM, Robert Richter <rric@xxxxxxxxxx> wrote: > > On 30.07.14 11:37:38, Rob Herring wrote: > >> On Wed, Jul 30, 2014 at 10:46 AM, Mark Rutland <mark.rutland@xxxxxxx> wrote: > >> > On Wed, Jul 30, 2014 at 04:06:31PM +0100, Robert Richter wrote: > >> >> From: Radha Mohan Chintakuntla <rchintakuntla@xxxxxxxxxx> > > > >> >> +/ { > >> >> + model = "Cavium ThunderX CN88XX Family"; > >> >> + compatible = "cavium,thunder-88xx"; > >> > > >> > Please don't use wildcards in compatible strings. Give this an absolute > >> > name, and override as necessary. > > > > The naming 88xx refers to the processor family and arn't actually > > wildcards. In the future we might need another dts file for 87xx, but > > so far all SoCs of 88xx family should use the same dts files. In this > > sense the naming is very specific. > > Yes, but each implementation can have its own errata. You might not > need to distinguish them now, but you could in the future. > > However, if the family is really all the same die and different parts > are just marketing, then the name is fine. Or if you can easily probe > the exact part and revision it's probably fine. Yes, this relates to the same soc. > > > > > > >> >> + cpus { > >> >> + #address-cells = <2>; > >> >> + #size-cells = <0>; > >> >> + > >> >> + cpu@000 { > >> >> + device_type = "cpu"; > >> >> + compatible = "cavium,thunder", "arm,armv8"; > >> >> + reg = <0x0 0x000>; > >> >> + enable-method = "psci"; > >> >> + }; > >> > > >> > Just to check: both the SoC and CPU are called thunder? > > > > The soc is called thunder-88xx, the cpu thunder. E.g. an 87xx soc will > > have the same core in which is thunder. > > And the next version of the core would be called something else? > thunder-v2? lightning? As long as they are distinguishable they should > be fine. Same here, the name relates to the same core. -Robert -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html