On 8/19/21 8:36 PM, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 19/08/2021 19:28, Pratyush Yadav wrote: >> + Tudor (you should be listed as a maintainer for this file IMO) >> >> On 19/08/21 06:59PM, Krzysztof Kozlowski wrote: >>> Document bindings for the issi,is25wp256 SPI NOR flash. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml >>> index ed590d7c6e37..0db64ac7dc33 100644 >>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml >>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml >>> @@ -33,6 +33,7 @@ properties: >>> - items: >>> - enum: >>> - issi,is25lp016d >>> + - issi,is25wp256 >> >> I don't think we want to add any new flash specific compatibles. Why is >> "jedec,spi-nor" not enough for you? > > It's fine for me. I had impression that specific compatibles are still > preferred and one of boards is using this one. The other way is to > remove this compatible from the board DTS. > Pratyush is right, we prefer to bind just to the generic "jedec,spi-nor" compatible whenever possible. Cheers, ta
