On Mon, Aug 16, 2021 at 5:38 PM Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote: > On Mon, Aug 16, 2021 at 6:48 PM zhiyong.tao <zhiyong.tao@xxxxxxxxxxxx> wrote: > > > I'll take that as "use SI units whenever possible and reasonable". > > > > ==> so It doesn't need to change the define, is it right? > > we will keep the common define. > > Actually I think it would be possible and reasonable to use SI units > in this case, since you are the vendor and have the resistor values > to implement the support. Having different sets of values for different > chips is nothing out of the ordinary. We already have to account for > different number of pins and different pin functions. That is what > compatible strings are for. I fully agree with Chen-Yu's analysis here. Zhiyong can you make an attempt to use SI units (Ohms) and see what it will look like? I think it will look better for users and it will be less risk to make mistakes. Yours, Linus Walleij