On Tue, 2021-07-13 at 15:17 +0800, Chen-Yu Tsai wrote: > Hi, > > On Sat, Jul 10, 2021 at 4:17 PM Zhiyong Tao <zhiyong.tao@xxxxxxxxxxxx> wrote: > > > > This patch adds rsel define for mt8195. > > > > Signed-off-by: Zhiyong Tao <zhiyong.tao@xxxxxxxxxxxx> > > --- > > include/dt-bindings/pinctrl/mt65xx.h | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/include/dt-bindings/pinctrl/mt65xx.h b/include/dt-bindings/pinctrl/mt65xx.h > > index 7e16e58fe1f7..f5934abcd1bd 100644 > > --- a/include/dt-bindings/pinctrl/mt65xx.h > > +++ b/include/dt-bindings/pinctrl/mt65xx.h > > @@ -16,6 +16,15 @@ > > #define MTK_PUPD_SET_R1R0_10 102 > > #define MTK_PUPD_SET_R1R0_11 103 > > > > +#define MTK_PULL_SET_RSEL_000 200 > > +#define MTK_PULL_SET_RSEL_001 201 > > +#define MTK_PULL_SET_RSEL_010 202 > > +#define MTK_PULL_SET_RSEL_011 203 > > +#define MTK_PULL_SET_RSEL_100 204 > > +#define MTK_PULL_SET_RSEL_101 205 > > +#define MTK_PULL_SET_RSEL_110 206 > > +#define MTK_PULL_SET_RSEL_111 207 > > + > > Instead of all the obscure macros and the new custom "rsel" property, > which BTW is not in the bindings, can't we just list the actual bias > resistance of each setting? We could also migrate away from R1R0. > ==>Hi Chenyu, The rsel actual bias resistance of each setting: MTK_PULL_SET_RSEL_000:75K in PU, 75k in PD; MTK_PULL_SET_RSEL_001:10k in PU, 5k in PD; MTK_PULL_SET_RSEL_010:5k in PU, 75k in PD; MTK_PULL_SET_RSEL_011:4k in PU, 5K in PD; MTK_PULL_SET_RSEL_100:3k in PU, 75k in PD; MTK_PULL_SET_RSEL_101:2k in PU, 5K in PD; MTK_PULL_SET_RSEL_110:1.5k in PU, 75k in PD; MTK_PULL_SET_RSEL_111:1k in PU, 5k in PD. The rsel actual bias resistance is different between PU and PD. > Then we can specify the setting with the standard bias-pull-up/down > properties [1]. > > Also, please ask internally if Mediatek could relicense all the header > files that Mediatek has contributed under include/dt-bindings/pinctrl/ [2] > to GPL-2.0 and BSD dual license. These files are part of the DT bindings > and we really want them to be dual licensed as well, and not just the > YAML files. > ==> We will confirm it internally and reply it later. Thanks. > > Regards > ChenYu > > > [1] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml#L37 > [2] Note that a few files were contributed by other people > > > #define MTK_DRIVE_2mA 2 > > #define MTK_DRIVE_4mA 4 > > #define MTK_DRIVE_6mA 6 > > -- > > 2.18.0 > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@xxxxxxxxxxxxxxxxxxx > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
