On 20:00-20210720, Aswath Govindraju wrote: > Hi Marc, > > On 20/07/21 7:50 pm, Marc Kleine-Budde wrote: > > On 20.07.2021 19:46:37, Aswath Govindraju wrote: > >> From: Faiz Abbas <faiz_abbas@xxxxxx> > >> > >> Add Support for two MCAN controllers present on the am65x SOC. Both support > >> classic CAN messages as well as CAN-FD. > > > > Thanks for the patch! > > > > Why don't you disable the CAN cores by default in the dtsi? > > As far as I know, in the dtsi file we mention all the subsystems or > periherals present in the SoC and in the specific board dts file we > enable or disable the DT nodes depending on whether the pins are > brought out. There is a long history on this. You should be able to look the discussion up in lore archives. The nutshell is the dtsi files should maintain DT standard which is "default, status if not explicitly provided is enabled" and the board dts files will explicitly disable OR reserve the nodes that are not pinned out / used / reserved (due to firmware usage) etc. There is the entire string parsing, size arguments that run around this topic, but, anyways. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
