Re: [PATCH] iio: st-sensors: Update ST Sensor bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 12, 2021 at 4:16 PM Maxime Ripard <maxime@xxxxxxxxxx> wrote:

> > maxItems is set, but not minItems.
>
> Yeah, and if one is missing the other is added with the value of the
> other.
>
> What the schema enforces currently is that (for the common part) the
> interrupt list can be between 1 and 2 and then for a specific set of
> compatibles (including the LIS3MDL) it has to be exactly 2.

maxItems is not an intuitive naming to what it does so it creates
bugs like this :/

Can you fix so it works with your PinePhone DTS and send a patch?
Perhaps also add as an example so it doesn't happen again?

> Even the common part looks weird though, it says that it can handle up
> to three interrupts but has maxItems: 2?

Maybe just drop maxItems for now?

Yours,
Linus Walleij



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux