On Mon, 12 Jul 2021 15:04:44 +0200 Maxime Ripard <maxime@xxxxxxxxxx> wrote: > Hi, > > On Mon, Apr 12, 2021 at 02:23:31PM +0200, Linus Walleij wrote: > > This adjusts the ST Sensor bindings with the more fine-grained > > syntax checks that were proposed late in the last kernel cycle > > and colliding with parallel work. > > > > Cc: devicetree@xxxxxxxxxxxxxxx > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > I'm not really sure of how I supposed to fix this, but this creates an > issue on the Pinephone > (arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts) that has a > LIS3MDL with only the DRDY pin routed and thus only has a single > interrupt in the DT. > > One of the if condition in that patch enforces that there's two > interrupts for the LIS3MDL, but it's not really clear to me why after > looking at the datasheet? It shouldn't be enforcing that 2 are specified rather that 2 'might' be specified. maxItems is set, but not minItems. Driver wise, at the moment it looks like we only handle one interrupt. So to handle selection when two are possible and either 1 or 2 might be wired up we need to add interrupt names (with default order so we don't break anything before adding them to the binding). Would that work for this device? Jonathan > > Maxime >
