Hi, On 05/06/2021 11:49, Martin Blumenstingl wrote: > Hi Nick, > > On Sat, Jun 5, 2021 at 5:09 AM <xieqinick@xxxxxxxxx> wrote: >> >> From: Nick Xie <nick@xxxxxxxxxx> >> >> Add Neural Network Accelerator device tree node >> for Khadas VIM3L. > we neither have a driver for this upstream nor any binding > documentation in Documentation/devicetree/bindings/ > are you planning to add this? > > Especially the missing binding documentation is problematic as it > causes some warnings when validating the .dts files against the > bindings from Documentation/devicetree/bindings/ Actually the NNA core is a verisilicon VIVANTE core, but I have no idea what is the difference with the VIVANTE GPU cores ? the userspace libraries & SDK shipped by Amlogic exposes OpenCL and (AFAIK) NNA over OpenCL, so I think the HW description should be similar to the current Etnaviv bindings. Neil > > > Best regards, > Martin >