Hi Nick, On 05/06/2021 08:23, xieqinick@xxxxxxxxx wrote: > From: Nick Xie <nick@xxxxxxxxxx> > > This patch series update / add serial and i2c aliases to > keep the same with 4.9 kernel for Khadas VIM boards > (VIM1, VIM2, VIM3 and VIM3L). > > Nick Xie (6): > arm64: dts: meson: vim3: add serial aliases > arm64: dts: meson: vim1: update serial aliases > arm64: dts: meson: vim2: update serial aliases > arm64: dts: meson: vim3: add i2c aliases > arm64: dts: meson: vim1: add i2c aliases > arm64: dts: meson: vim2: add i2c aliases > > .../boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 8 +++++++- > arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 7 ++++++- > arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 9 +++++++++ > 3 files changed, 22 insertions(+), 2 deletions(-) > Thanks for these patches. I'm not sure about the current policy about aliases, but when we started upstreaming the amlogic boards, only the exposed interfaces could have an alias and in the board.dts file only. But since other vendors added a bunch of aliases of all the possible i2c/spi/uart/mmc/ethernet interfaces in the SoC dtsi.... But the question of the 40pins header remains, should we add aliases for interfaces present on the 40pin header ????? Personally, we should'nt since these pins has no defined functions, so any alias should be added by a DT overlay loaded from U-boot. But it's my own opinion. Rob ? what's the current policy on that ? Neil
