Re: [PATCH v20 08/19] dt-binding: memory: pl353-smc: Fix the reg property in the example

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 19, 2021 at 08:26:25PM +0200, Miquel Raynal wrote:
> The reg property should describe the entire accessible zone, not only
> the one the driver wants to access. With this in mind, the example
> should map two regions instead of one to be entirely accurate.

No, not really. The address space is already covered by 'ranges'. Unless 
you need the range in the arm,pl353-smc-r2p1 driver.

> 
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/memory-controllers/pl353-smc.txt       | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> index 1335b94291ad..9d220d4cb39d 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> @@ -27,7 +27,8 @@ Example:
>  		compatible = "arm,pl353-smc-r2p1", "arm,primecell";
>  		clock-names = "memclk", "apb_pclk";
>  		clocks = <&clkc 11>, <&clkc 44>;
> -		reg = <0xe000e000 0x1000>;
> +		reg = <0xe000e000 0x0001000>,
> +		      <0xe1000000 0x5000000>;
>  		#address-cells = <2>;
>  		#size-cells = <1>;
>  		ranges = <0x0 0x0 0xe1000000 0x1000000 /* Nand CS region */
> -- 
> 2.27.0
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux