On 22/04/2021 20:20, Heiko Stübner wrote: > Hi, > > Am Donnerstag, 22. April 2021, 00:12:45 CEST schrieb Johan Jonker: >> On 4/21/21 11:56 PM, Ezequiel Garcia wrote: >>> On Wed, 2021-04-21 at 23:25 +0200, Johan Jonker wrote: >>>> On 4/21/21 11:06 PM, Ezequiel Garcia wrote: >>>>> On Wed, 2021-04-21 at 22:46 +0200, Johan Jonker wrote: >>>>>> On 4/21/21 10:04 PM, Ezequiel Garcia wrote: >>>>>>> Add a new compatible for the thermal sensor device on RK3568 SoCs. >>>>>>> >>>>>>> Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> >>>>>>> --- >>>>>>> Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 + >>>>>>> 1 file changed, 1 insertion(+) >>>>>>> >>>>>>> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >>>>>>> index 7f94669e9ebe..346e466c2006 100644 >>>>>>> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >>>>>>> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >>>>>>> @@ -9,6 +9,7 @@ Required properties: >>>>>>> "rockchip,rk3328-tsadc": found on RK3328 SoCs >>>>>>> "rockchip,rk3368-tsadc": found on RK3368 SoCs >>>>>>> "rockchip,rk3399-tsadc": found on RK3399 SoCs >>>>>> >>>>>>> + "rockchip,rk3568-tsadc": found on RK3568 SoCs >>>>>> >>>>>> This is still a text document. >>>>>> rob+dt has now scripts that check for undocumented compatibility >>>>>> strings, so first convert rockchip-thermal.txt to YAML and then add this >>>>>> in a separated patch. >>>>>> >>>>> >>>>> Is it a showstopper to convert devicetree bindings to YAML for driver submission? >>>> >>>> You now that hardware best, so try to fix the documents as well. >>> >>> Well, not really. I'm just forward porting the driver from downstream kernels, >>> so we can support this new SoC. Not really a hardware _expert_ for all the >>> devices I plan to be pushing. >>> >>>> The new norm is YAML, so aim for that. >>> >>> I am aware of that. In fact, at Collabora we encourage all the kernel >>> developers to convert to YAML, if/when possible. >>> >>>> Try to submit a complete package of YAML, driver (and dts nodes) for review. >>> >>> The devicetree for RK3566 and RK3568 is under discussion, in fact it was submitted today. >>> Rockhip is leading that, and doing a great job already :) >>> >>> Meanwhile, I'd like to merge the small drivers (thermal, pmic, dwmac, io-domains and so on), >>> so they are ready when the devicetree lands. >>> >> >>> Most if not all of these devices just need a new compatible string. It would really delay >>> things if I aim to convert all those bindings docs to YAML first, so let's please avoid that... >>> ... unless it's a new hard-rule that DT maintainers have agreed on. >> >> Every driver group has it's own delay time, so better do it right in one >> run. >> Mostly people tend to 'forget' documentation and then someone else has >> to clean up the mess. So I propose that the person that submits a new >> driver also fixes the documentation. The norm is now YAML, so this serie >> has more work then other, so be it. Others can help you with it if you ask. > > personally I feel this approach being a bit too strict. > > While it is definitly cool to convert everything to a yaml base in a > hopefully short time, being overly strict can also stiffle participation. +1 -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
