Hi Daniel, On 1/22/21 9:32 PM, Daniel Walker (danielwa) wrote: > On Fri, Jan 22, 2021 at 09:48:53AM +0100, Michal Simek wrote: >> Hi Daniel, >> >> On 1/22/21 12:12 AM, Daniel Walker wrote: >>> Add Petra and Hellcat dts file. These platforms are based on >>> the Xilinx Zynqmp platform. >>> >>> Signed-off-by: Daniel Walker <dwalker@xxxxxxxxxx> >>> Cc: xe-linux-external@xxxxxxxxx >>> --- >>> arch/arm64/boot/dts/xilinx/Makefile | 2 + >>> .../boot/dts/xilinx/zynqmp-petra-hellcat.dts | 856 ++++++++++++++++++ >>> arch/arm64/boot/dts/xilinx/zynqmp-petra.dts | 847 +++++++++++++++++ >>> 3 files changed, 1705 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-petra-hellcat.dts >>> create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-petra.dts >> >> First of all I can't see 2/2. > > It wasn't being submitted to you. But here it is if you care to look at it. > > https://lkml.org/lkml/2021/1/21/1468 I think spi-dev should enable the same approach as is used by uio driver. Take a look at 05c3e0bb5629b897b0459e4bfb1b93d729033b99 But it is up to Mark it this could be reasonable solution for this driver. > >> >> Long time ago we said that we are not going to push any PL related >> configurations. It means all below can't be merged. >> And there are also coding style issues. > > You'll need to explain this more. It's likely this was added at the suggestion of > Xilinx. If it can't be upstreamed what should we replace it with ? No idea who gave you this suggestion from Xilinx. I had similar thread with Michael Walle about supporting Ebang board. PL depends on your custom design and can change quite quickly that's there is no good/bad configuration. That's why all of them can be valid and kernel is not the right location to store thousands of configurations (likely in overlay form). That's why only fixed configurations for PS are added to kernel. And I prefer if there is any good reason behind why these platforms should be added. > I will review your other comments and re-submit. Happy to take a look at it again but completely remove PL description. Thanks, Michal
