On Fri, Jan 22, 2021 at 3:54 AM Jernej Škrabec <jernej.skrabec@xxxxxxxx> wrote: > > Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a): > > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > > packet loss rates. The realtek phy driver overrides the settings of the > > pull ups for the delays, so fix this for Banana Pro. > > > > Signed-off-by: Hermann Lauer <Hermann.Lauer@xxxxxxxxxxxxxxxxx> > > Much better. Now the only thing missing is "Fixes" tag, which references > commit which introduced the issue. Probably this will be the commit which > added ethernet node. This tag is important for deciding which commits should > be backported to stable releases. Take a look in v1 for M2U fixes tag. > > Btw, each version should have changelog under "---" line, so maintainers and > reviewers know what changed. The subject line should also be more concise. "Fix ethernet phy-mode" reads much better than "Fix ethernet node", which could mean a number of things. ChenYu
