Hi Shawn, > > + can0: can@2180000 { > > + compatible = "fsl,lx2160ar1-flexcan"; > > + reg = <0x0 0x2180000 0x0 0x10000>; > > + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clockgen 4 7>, <&sysclk>; > > Can defines in dt-bindings/clock/fsl,qoriq-clockgen.h be useful? Sure, I will update the constants with qoriq-clockgen defines. Actually, the time I posted the patch, those series of patches were not accepted. I will update and resend the series. Thanks Kuldeep