On 18/06/2014 10:36, Lee Jones wrote: > On Tue, 17 Jun 2014, Boris BREZILLON wrote: > >> Add support for the AXP221 PMIC device to the existing AXP20x driver. >> >> The AXP221 defines a new set of registers, power supplies and regulators, >> but most of the API is similar to the AXP20x ones. >> The AXP20x irq chip definition is reused, though some interrupts are not >> available in the AXP221. >> >> Signed-off-by: Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx> >> --- >> drivers/mfd/axp20x.c | 64 ++++++++++++++++++++++++++++++++++++++++++---- >> include/linux/mfd/axp20x.h | 56 ++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 115 insertions(+), 5 deletions(-) > Looks good to me now. > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> > > Can this go in independently to the other patches in the set? Yes, as long as no one define an axp221 node in his DT. In this case axp221 regulators would be considered as axp20x ones (which might be a bit problematic), because axp20x-regulator driver does not test the axp variant before probing its regulators (this test is introduced in patch 3). Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
