Re: [PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop rxc-skew-ps from ethernet-phy node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

On Fri, Oct 16, 2020 at 8:15 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Subject: Re: [PATCH 1/2] arm64: dts: renesas: hihope-rzg2-ex: Drop rxc-
> > skew-ps from ethernet-phy node
> > On Thu, Oct 15, 2020 at 3:24 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > wrote:
> > > HiHope RZG2[HMN] boards uses Realtek phy and the driver does not
> > > support rxc-skew-ps property. So remove rxc-skew-ps from ethernet-phy
> > node.
> > >
> > > Fixes: 7433f1fb8ec8fe ("arm64: dts: renesas: Add HiHope RZ/G2M sub
> > > board support")
> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-
> > lad.rj@xxxxxxxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
> > > @@ -23,7 +23,6 @@
> > >         status = "okay";
> > >
> > >         phy0: ethernet-phy@0 {
> > > -               rxc-skew-ps = <1500>;
> > >                 reg = <0>;
> > >                 interrupt-parent = <&gpio2>;
> > >                 interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> >
> > Should "rx-internal-delay-ps = <1800>" be added to the avb node instead
> > (after [1] has entered v5.10-rc1, and the DTS part of [2] has been  applied to
> > renesas-devel)?
>
> Looking at the schematic, it is not needed, since it has "2ns" internal delay  (4.7K Ohm latched to 2.5 V) on the Rx side.

Thanks for the pointer, I can confirm LED2_RXDLY is strapped high
(to 3.3V, not 2.5V though).

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v5.11.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux