Re: [PATCH RESEND v7 1/3] dt-bindings: usb: hd3ss3220 device tree binding document

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

On Wed, Sep 4, 2019 at 10:22 AM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote:
> Add device tree binding document for TI HD3SS3220 Type-C DRP port
> controller driver.
>
> Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt
> @@ -0,0 +1,38 @@
> +TI HD3SS3220 TypeC DRP Port Controller.
> +
> +Required properties:
> + - compatible: Must be "ti,hd3ss3220".
> + - reg: I2C slave address, must be 0x47 or 0x67 based on ADDR pin.
> + - interrupts: An interrupt specifier.
> +
> +Required sub-node:
> + - connector: The "usb-c-connector" attached to the hd3ss3220 chip. The
> +   bindings of the connector node are specified in:
> +
> +       Documentation/devicetree/bindings/connector/usb-connector.txt
> +
> +Example:
> +hd3ss3220@47 {
> +       compatible = "ti,hd3ss3220";
> +       reg = <0x47>;
> +       interrupt-parent = <&gpio6>;
> +       interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +
> +       connector {
> +               compatible = "usb-c-connector";
> +               label = "USB-C";
> +               data-role = "dual";
> +
> +               ports {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +
> +                       port@1 {

This does not comply with
Documentation/devicetree/bindings/connector/usb-connector.yaml:

    connector: ports: 'port@0' is a required property

> +                               reg = <1>;
> +                               hd3ss3220_ep: endpoint {
> +                                       remote-endpoint = <&usb3_role_switch>;
> +                               };
> +                       };
> +               };
> +       };
> +};

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux